Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of watch notice errors from k8s #393

Merged
merged 1 commit into from
Aug 26, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,12 @@ def collector_thread
self.watch ||= connection(entity_type).send("watch_#{entity_type}", :resource_version => resource_version)

watch.each do |notice|
# If we get a 410 gone with this resource version break out and restart
# the watch
if notice.kind == "Status" && notice.code == 410
_log.warn("Caught 410 Gone, restarting watch")
if notice.type == "ERROR"
message = notice.object&.message
code = notice.object&.code
reason = notice.object&.reason

_log.warn("Received an error watching #{entity_type}: [#{code} #{reason}], [#{message}]")
break
end

Expand Down