Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that KubeVirt is OSV #532

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Clarify that KubeVirt is OSV #532

merged 1 commit into from
Jul 17, 2024

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jul 17, 2024

@agrare Please review.

@agrare
Copy link
Member

agrare commented Jul 17, 2024

@Fryguy I thought we were going to add a subclass of the KubeVirt provider for Openshift Virtualization? We can do this too but I think when we have a proper provider type we would revert this.

@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2024

Checked commit Fryguy@ee75a69 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy
Copy link
Member Author

Fryguy commented Jul 17, 2024

@agrare Yeah this is a temporary fix just to make it clear in the UI - Agreed that once we have the dedicated provider, then we revert this.

@agrare agrare merged commit 8160dd7 into ManageIQ:master Jul 17, 2024
4 checks passed
@Fryguy Fryguy deleted the add_osv branch July 17, 2024 19:43
@Fryguy
Copy link
Member Author

Fryguy commented Aug 15, 2024

Backported to radjabov via merge of master into radjabov branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants