Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Track changes to VMs cpu/memory #844

Closed
wants to merge 1 commit into from

Conversation

agrare
Copy link
Member

@agrare agrare commented Dec 21, 2022

Example payload in the callback:

hardwares.record_changes
{19000000007654=>{"cpu_sockets"=>[1, 2], "memory_mb"=>[64, 1024], "cpu_cores_per_socket"=>[1, 2], "cpu_total_cores"=>[1, 4]}}

Depends on:

@agrare agrare requested a review from Fryguy as a code owner December 21, 2022 17:40
@agrare agrare added the wip label Dec 21, 2022
@agrare
Copy link
Member Author

agrare commented Dec 21, 2022

@miq-bot cross-repo-tests ManageIQ/inventory_refresh#115

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Dec 21, 2022
@miq-bot
Copy link
Member

miq-bot commented Dec 21, 2022

Checked commit agrare@a236879 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 3 offenses detected

app/models/manageiq/providers/vmware/infra_manager/inventory/persister.rb

  • ⚠️ - Line 87, Col 36 - Lint/UnusedBlockArgument - Unused block argument - ems. If it's necessary, use _ or _ems as an argument name to indicate that it won't be used.
  • ❗ - Line 92, Col 9 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.

spec/models/manageiq/providers/vmware/infra_manager/refresher_spec.rb

@miq-bot miq-bot added the stale label Mar 27, 2023
@miq-bot
Copy link
Member

miq-bot commented Mar 27, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot closed this Jul 3, 2023
@miq-bot
Copy link
Member

miq-bot commented Jul 3, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@agrare agrare reopened this Jul 3, 2023
@miq-bot miq-bot closed this Oct 9, 2023
@miq-bot
Copy link
Member

miq-bot commented Oct 9, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants