Use namespaced gem require instead of hyphenated name #22548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both work but the namespaced name is more friendly to zeitwerk in the future. Related: ManageIQ#22000
55 tasks
Fryguy
approved these changes
Jun 5, 2023
|
Checked commit jrafanie@c56392d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
This was referenced Jun 5, 2023
Merged
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Jun 7, 2023
…r_zeitwerk Use namespaced gem require instead of hyphenated name (cherry picked from commit 7a40ae4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both work but the namespaced name is more friendly to zeitwerk in the future.
Related: #22000
Note, this was extracted from #22488 as it's completely backward compatible.
Related to ManageIQ/amazon_ssa_support#96