Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Virtual attributes for Containers and friends (performance changes) #22575

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Virtual attributes for Containers and friends (performance changes) #22575

wants to merge 2 commits into from

Commits on Oct 20, 2023

  1. add ContainerGroup#ready_condition_status 

    similar to 773fea3

already introduced indexes, so this is just ruby changes

|     ms |query | qry ms |     rows |` comments`
|    ---:|  ---:|   ---:|      ---:|  ---
|  347.2 |   32 |  53.2 |      128 |` /container_node/report_data#node-index`
|  308.8 |   11 |  10.3 |       28 |` /container_node/report_data#node-after`
|  11.1% |  66% | 80.6% |      78% | diff

|     ms |query | qry ms |     rows |` comments`
|    ---:|  ---:|   ---:|      ---:|  ---
|  428.0 |   32 | 123.2 |       88 |` /container_group/report_data#group-index`
|  336.5 |   11 |  65.5 |       28 |` /container_group/report_data#group-after`
|  21.4% |  66% | 46.8% |      68% | diff
    @kbrock
    kbrock committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    53e9556 View commit details
    Browse the repository at this point in the history

  2. add ContainerImageRegistry#full_name arel 

    add ContainerImage#display_registry delegate to the full_name

|     ms |query | qry ms |     rows |` comments`
|    ---:|  ---:|   ---:|      ---:|  ---
|  424.3 |   51 |  98.7 |       48 |` /container_image/report_data`
|  345.1 |   11 |  34.4 |       28 |` /container_image/report_data`
|   18.7%|   78%|  65.1%|       42%| diff

Localization of "Unknown image source" has been removed and moved
into the UI layer
    @kbrock
    kbrock committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    4cb708a View commit details
    Browse the repository at this point in the history