Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Arel helper methods to generate arel #22581

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Use Arel helper methods to generate arel #22581

merged 5 commits into from
Aug 10, 2023

Commits on Jul 15, 2023

  1. Use arel's build in coalesce factory

    @kbrock
    kbrock committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    b3fe70b View commit details
    Browse the repository at this point in the history

  2. Use Arel.sql factory to generate SqlLiterals

    @kbrock
    kbrock committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    5f9b95e View commit details
    Browse the repository at this point in the history

  3. Use arel's lower factory method to simplify arel generation code

    @kbrock
    kbrock committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    e96c6e1 View commit details
    Browse the repository at this point in the history

  4. Service::Aggregation - drop unneeded arel creation methods 

    these methods are only used once. Now that they are less verbose,
best to just drop them.
    @kbrock
    kbrock committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    9cec858 View commit details
    Browse the repository at this point in the history

  5. remove ambiguous multiplication 

    rubocop requested this:

> Wrap expressions with varying precedence with parentheses to avoid ambiguity.
    @kbrock
    kbrock committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    e6b721d View commit details
    Browse the repository at this point in the history