[WIP] Only collect rollup associations #22609
Conversation
kbrock
changed the title
|
WIP: code is done. need to research whether we use any of these other associations |
|
update:
|
kbrock
force-pushed
the
vps_associations
branch
3 times, most recently
from
fd43d93
to
14a8029
Compare
|
update:
|
| if defined?(self.class::PERF_ROLLUPS) | ||
| self.class::PERF_ROLLUPS | ||
| else | ||
| self.class::PERF_ROLLUP_CHILDREN.each_with_object({}) { |x, h| h[x] = x } | ||
| end |
There was a problem hiding this comment.
This makes me think that instead of introducing a new constant that partially duplicates PERF_ROLLUP_CHILDREN that we should just outright change PERF_ROLLUP_CHILDREN.
There was a problem hiding this comment.
I understand that they serve 2 different purposes, so perhaps the other option is a better name than PERF_ROLLUPS; perhaps VIM_PERFORMANCE_STATE_ROLLUP_CHILDREN?
|
outstanding:
thoughts:
|
|
This pull request is not mergeable. Please rebase and repush. |
|
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
kbrock
force-pushed
the
vps_associations
branch
from
4507bf0
to
ac70b26
Compare
|
update:
comments:
|
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
consolidate logic for association names
Kubernetes currently defines this, but making it generic for all child container managers
before, the rollups were limited now, unsure not sure if clearing associations code is still valid
kbrock
force-pushed
the
vps_associations
branch
from
ac70b26
to
5b45f67
Compare
|
Checked commits kbrock/manageiq@172dcbe~...5b45f67 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint app/models/metric/ci_mixin/state_finders.rb
|
|
update: in a WIP state. getting ready to green-red-green that the rollups are correct. all the warnings highlight temporary code that want to remove. |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
1 similar comment
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
VimPerformanceStateare used to represent an object in the past.These records are used for metrics rollups, metric calculations, and chargeback calculations.
Do note, that chargeback calculations do contain some form of a rollup.
We only rollup metrics by the
PERF_ROLLUP_CHILDRENassociation.Collecting all these other grow our
VimPerformanceStatetable and take up processing timefor collecting vps and downloading vps.
Goal v2
The caching and others assume that the name of the association is the kind of association. so vms is stored in 'Model#vms'. But as seen, sometimes we take vms from all_vms_and_templates and others.
The goal is to define in the model the associations.
From here, hopefully we can prune out any associations that don't make sense. (which will give us a big reduction in speed of creating a VimPerformanceState and the amount of data stored in the database.)