Change plugin setup to more closely match core setup #22627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
commented
Jul 21, 2023
Fryguy
force-pushed
the
better_env_var_plugin_setup
branch
from
96d94dc
to
86826d9
Compare
agrare
approved these changes
Jul 21, 2023
- Honor the SKIP_DATABASE_RESET env var and default to true on CI - ensure_config_files before bundler setup
Fryguy
force-pushed
the
better_env_var_plugin_setup
branch
from
86826d9
to
4602f61
Compare
|
Some comments on commit Fryguy@4602f61 lib/manageiq/environment.rb
|
|
Checked commit Fryguy@4602f61 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@agrare Please review. This is the followup from #22626 (comment)