Fix undefined method reject! in allowed_storages #22636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot cross-repo-tests manageiq-content |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Jul 25, 2023
From Pull Request: ManageIQ/manageiq#22636
|
LGTM - would it be possible to get some specs for these cases into the core repo? |
agrare
force-pushed
the
fix_allowed_storages_storage_profile
branch
2 times, most recently
from
c26ae68
to
5a49403
Compare
In the case where a StorageProfile is selected we were failing to filter out the allowed storages due to the `storages` variable now being an ActiveRecord Association where `#reject!` isn't defined. This also resolves an N+1 issue where each storage queries for all storage_profiles.
agrare
force-pushed
the
fix_allowed_storages_storage_profile
branch
from
5a49403
to
cee957b
Compare
|
Checked commit agrare@cee957b with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
bdunne
approved these changes
Jul 25, 2023
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Jul 25, 2023
…ofile Fix undefined method reject! in allowed_storages (cherry picked from commit b64767d)
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Jul 26, 2023
…ofile Fix undefined method reject! in allowed_storages (cherry picked from commit b64767d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where a StorageProfile is selected we were failing to filter out the allowed storages due to the
storagesvariable now being an ActiveRecord Association where#reject!isn't defined.This also resolves an N+1 issue where each storage queries for all storage_profiles.
Failing spec: https://github.com/ManageIQ/manageiq-content/actions/runs/5651086179/job/15308573621
Related: #22625