Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rails 7 deprecation #23083

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Jul 11, 2024

Part of #22052

Fixes the warning:

DEPRECATION WARNING: ActiveSupport::TimeWithZone.name has been deprecated and
from Rails 7.1 will use the default Ruby implementation.
You can set `config.active_support.remove_deprecated_time_with_zone_name = true`
to enable the new behavior now.
 (called from block in ruby_object_usage at manageiq/app/models/miq_worker/runner.rb:435)

Super easy backwards compatible change extracted from #22873

Fixes the warning:

DEPRECATION WARNING: ActiveSupport::TimeWithZone.name has been deprecated and
from Rails 7.1 will use the default Ruby implementation.
You can set `config.active_support.remove_deprecated_time_with_zone_name = true`
to enable the new behavior now.
 (called from block in ruby_object_usage at /Users/joerafaniello/Code/manageiq/app/models/miq_worker/runner.rb:435)
@jrafanie jrafanie changed the title Fix rails 7 deprecations Fix rails 7 deprecation Jul 11, 2024
@miq-bot
Copy link
Member

miq-bot commented Jul 11, 2024

Checked commit jrafanie@f3afb49 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@jrafanie
Copy link
Member Author

This one liner is ready for review/merge. Thanks!

@Fryguy Fryguy added the bug label Jul 17, 2024
@Fryguy Fryguy assigned kbrock and unassigned Fryguy Jul 17, 2024
@kbrock kbrock merged commit 2b57f9a into ManageIQ:master Jul 17, 2024
8 checks passed
@jrafanie jrafanie deleted the fix_rails_7_deprecations branch July 17, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants