Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused tota11y.js reference #23227

Merged
merged 1 commit into from
Oct 10, 2024
Merged

remove unused tota11y.js reference #23227

merged 1 commit into from
Oct 10, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Oct 10, 2024

followup to ManageIQ/manageiq-ui-classic#3406

remove tota11y assets from core

followup to ManageIQ/manageiq-ui-classic#3406

remove tota11y assets from core
@kbrock kbrock added the cleanup label Oct 10, 2024
@kbrock kbrock requested a review from jrafanie as a code owner October 10, 2024 18:55
@kbrock kbrock changed the title remove tota11y remove unused tota11y.js reference Oct 10, 2024
@miq-bot
Copy link
Member

miq-bot commented Oct 10, 2024

Checked commit kbrock@01d0742 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@jrafanie
Copy link
Member

tota11y awesome 🗑️ ✂️ 🚽

@jrafanie jrafanie merged commit 4622f5f into ManageIQ:master Oct 10, 2024
12 checks passed
@jrafanie jrafanie self-assigned this Oct 10, 2024
@Fryguy
Copy link
Member

Fryguy commented Oct 10, 2024

I'm good with this...it can always be added in manually in the future if needed. Regardless, the team has been using the IBM Accessibilty Checker lately, so this isn't used.

@kbrock kbrock deleted the tota11y branch October 10, 2024 20:18
@kbrock
Copy link
Member Author

kbrock commented Oct 10, 2024

yea. but it was removed from bower/package.json 4 years ago. and there were no javascript include tags - so it was probably just silently failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants