Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rspec-rails for rails 7.1 support #23245

Merged

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Oct 28, 2024

6.1.0 added rails 7.1 support
6.1.1 added some rails 7.1 improvements

Move to the latest release and allow for minor updates. It's unclear why we need to be so pessimistic about upgrades. We need to stay more current.

6.1.0 added rails 7.1 support
6.1.1 added some rails 7.1 improvements

Move to the latest release and allow for minor updates.  It's unclear why we need
to be so pessimistic about upgrades.  We need to stay more current.
@jrafanie jrafanie requested a review from Fryguy as a code owner October 28, 2024 19:37
@jrafanie jrafanie changed the title Upgrade rspec-rails for rails 7.1 support [WIP] Upgrade rspec-rails for rails 7.1 support Oct 28, 2024
@jrafanie
Copy link
Member Author

@miq-bot cross-repo-tests /all

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Oct 28, 2024
@jrafanie jrafanie removed the wip label Oct 28, 2024
@jrafanie jrafanie changed the title [WIP] Upgrade rspec-rails for rails 7.1 support Upgrade rspec-rails for rails 7.1 support Oct 28, 2024
@bdunne bdunne merged commit 542f052 into ManageIQ:master Oct 29, 2024
12 checks passed
@bdunne bdunne self-assigned this Oct 29, 2024
@jrafanie jrafanie deleted the upgrade-rspec-rails-for-rails-7-1-support branch October 29, 2024 15:32
@jrafanie jrafanie mentioned this pull request Oct 30, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants