Fix deprecations using activesupport deprecation #23249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables us to move away from the singleton ActiveSupport::Deprecation methods and towards instances and will allow us to use our own deprecator more easily.
Note, this deprecation was originally done for zeitwerk/namespace loading and should be removed soon. It was added originally in: 9e0de20
|
@miq-bot cross-repo-tests /all |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Oct 30, 2024
From Pull Request: ManageIQ/manageiq#23249
jrafanie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #23225
Don't use singleton, use a deprecator. We already had instance, which is a deprecator so make that obvious.
As an aside, I think some of these deprecations should be reviewed for deletion before the next release.