Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to simplified release workflow #44

Merged
merged 2 commits into from
Sep 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions .github/workflows/create_release.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,13 @@
# Create a draft release and build and upload all installers to it.
name: Create Draft Release
name: Create Release

on:
workflow_dispatch:
inputs:
commit_to_release:
description: 'Enter commit hash to release (example: ef4037cb571f99cb4919b520fde7174972aae473)'
commitish_to_release:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo commitish?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, apparently that's a thing https://git-scm.com/docs/gitglossary

type: string
required: true
tag_to_release:
description: 'Enter tag to release (example: v1.5.5)'
type: string
required: true
description: 'Enter commit hash or branch to release (default: main).'
default: "main"

jobs:
create-release:
Expand All @@ -21,7 +17,6 @@ jobs:
contents: write
with:
package_name: directlfq
build_nodejs_ui: false
commit_to_release: ${{ inputs.commit_to_release }}
tag_to_release: ${{ inputs.tag_to_release }}
python_version: "3.8"
commitish_to_release: ${{ inputs.commitish_to_release }}
python_version: 3.8
test_app: false
Loading