Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement pre-commit rules #84

Merged
merged 12 commits into from
Sep 26, 2024
Merged

implement pre-commit rules #84

merged 12 commits into from
Sep 26, 2024

Conversation

sophiamaedler
Copy link
Collaborator

implement suggested pre-commit rules according to coding best practices #43.

This PR implements all rules except Docstring formats and use of path lib as this requires more manual changes and will be done separately.

Copy link
Collaborator

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohooo that's great! I know that this is pretty annoying work but maybe it also taught a thing or two.

@sophiamaedler
Copy link
Collaborator Author

It wasn't too bad actually. And indeed: I did learn a little more about exceptions and exception handling.

Not looking forward to the docstrings though :P

@sophiamaedler sophiamaedler merged commit b3adf54 into main Sep 26, 2024
2 checks passed
@sophiamaedler sophiamaedler deleted the fix_linting branch September 26, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants