Skip to content

fix(web): agent session detail feedback round two - #633

Merged
JeremyFunk merged 2 commits into
mainfrom
fix/agent-session-detail-feedback-2
Aug 25, 2026
Merged

fix(web): agent session detail feedback round two#633
JeremyFunk merged 2 commits into
mainfrom
fix/agent-session-detail-feedback-2

Conversation

@JeremyFunk

@JeremyFunk JeremyFunk commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

A second round of feedback fixes on the agent session detail page, verified against the /lab/agent-session fixture.

What changed

Scrollbar clearance + overflow guard. The detail page's scroller now carries pr-6 so the overlay scrollbar sits clear of the right-aligned duration/cost columns, and overflow-x-hidden so no stray span can ever put the whole page into a horizontal scroll.

Long names contained everywhere. Agent names are emitter input, so every place one rendered unbounded now caps and truncates (full value in title): the Overview's Agents rail pills, the transcript's turn-header agent pill, lane open/close rows, "ran in parallel with" jump chips, parallel-marker lane buttons, tool and structure row labels, the collapsed-turn summary (which joins every tool name in the turn), and the waterfall's span-name cell. Stress-tested with a 100-char agent name and a multi-thousand-word prompt: no view overflows.

Interactable Tools rail. SessionToolUsage now carries gen_ai.tool.description (from the first span that stamped one), and an Overview tool row with a description discloses it in place. Tools without one stay plain rows. The lab fixture stamps descriptions on four tools so both shapes render.

Flow panning constrained. The canvas gets a translateExtent computed from the node bounding box plus a 400px margin — a fling can no longer strand the reader on blank canvas with no node in sight.

Traces rows read by glyph. Span rows draw the Flow view's category icons (agent/inference/tool, with error taking the glyph over) instead of colored dots; rows go 26px → 28px for the extra weight. The Flow drawer header names its span with the same glyph.

User input clamps. Transcript user blocks render through the shared ClampedText: twelve lines with Show full / Show less, in both markdown and raw views, with the disclosure held in openRows so it survives virtualization.

Also rides along: bun.lock prunes the stale lib/llm workspace entry left behind when #626 replaced the vendored copy with @opencode-ai/ai.

Verification

  • apps/web typecheck clean; all 271 agent-session tests pass, including a new one for the description pickup.
  • Every view eyeballed in the lab harness, including a temporary long-name/long-prompt fixture stress patch (reverted before commit).

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

- Detail page scroller gets pr-6 so the overlay scrollbar clears the
  right-aligned duration/cost columns, and overflow-x-hidden so nothing
  can make the page scroll sideways.
- Agent names, tool names and joined tool summaries truncate everywhere
  they render — Overview agent pills, transcript turn/lane headers,
  parallel jump chips, structure rows, waterfall span names — instead of
  widening the page.
- The Overview's Tools rail is interactable: a tool whose spans stamped
  gen_ai.tool.description discloses it in place.
- The Flow canvas constrains panning to the graph's bounding box plus a
  margin, so a fling can no longer strand the reader on blank canvas.
- Traces rows draw the Flow view's category glyphs instead of colored
  dots (rows 26px -> 28px for the extra weight); the Flow drawer header
  uses the same glyph.
- User blocks in the transcript clamp at twelve lines with the shared
  Show full / Show less control, in both markdown and raw views.
@JeremyFunk
JeremyFunk merged commit c28d83b into main Aug 25, 2026
5 checks passed
@JeremyFunk
JeremyFunk deleted the fix/agent-session-detail-feedback-2 branch August 25, 2026 18:35
@github-actions

Copy link
Copy Markdown

🍁 Maple PR preview

Warning

Preview cleanup could not be confirmed. The Alchemy teardown outcome was skipped.

Final commit cd20eb8 · View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant