Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #328 #334

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Fix for #328 #334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d901122
add warning if glmm.solver is NULL and using GLMM
MikeDMorgan Jun 3, 2024
43c0f9c
Merge branch 'devel'
MikeDMorgan Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions R/testNhoods.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,13 @@ testNhoods <- function(x, design, design.df, kinship=NULL,

# I think these need to be logged
offsets <- log(dge$samples$norm.factors)

# if glmm.solver isn't set but is running GLMM
if(is.null(glmm.solver) & isTRUE(is.lmm)){
warning("NULL value for glmm.solver - setting to Fisher. Please set glmm.solver")
glmm.solver <- "Fisher"
}

glmm.cont <- list(theta.tol=max.tol, max.iter=max.iters, solver=glmm.solver)

#wrapper function is the same for all analyses
Expand Down
Loading