-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding profile support #6
Conversation
Yeah, I'm fine with it. #edit |
It's a https://romanvm.github.io/Kodistubs/_autosummary/xbmcgui.html#xbmcgui.Dialog.select Maybe |
Ok, I see. This looks good. The second line could be last login if possible. |
@heppen-dev yeah I just tried out the Ones that look interesting to me are: {
"isOwner": true,
"type": "adult",
"restricted": false,
"language": "nl",
} |
Basically this 3 infos are usefull:
Just say when you are ready and we can merge :) |
This would be the simplest way to implement a profile screen, you could also use the preselect method if there is a main account that you would like to highlight. |
@heppen-dev like so? Only downside to this is, all of these values are internal ones from the API (not labels). We'd have to translate them ourselves. @Mariusz89B Yeah I spotted the preselect, I've got that already implemented as, the current profile or none preselected. |
Pushed that change, though none of it is translated yet. |
It seems, profile does not works well with different Viaplay versions. We need more test before merge. |
@heppen-dev do you mean on other countries' sites? Which ones are you trying and what does it do? Silently ignore profiles or errors? |
A solution would be to set a single user as an exception if there is missing information in the json dictionary and it's silently ignoring profiles. |
Hey @Beanow we have added profiles support to our repository with @zuzia-dev |
@heppen-dev your version seems to work with NL as well. Closing this, as your fixes seem preferable. |
There was a KeyError related to language key in response. It's not exist in some sites. |
Fixes emilsvennesson#34
Making a draft PR to get your feedback on this so far. It adds "Select profile" and "Log out" to the settings.
(As well as the user_id and profile_id, while it's in development, final would hide those.)
It will automatically ask to choose a profile when opening the root page, if you haven't already.
Kind of like the "Who's watching?" dialog on the official apps.
An easy way to verify your profile is correctly selected, is to see if
viaplay:starred
orviaplay:watched
has the correct items.@Mariusz89B @heppen-dev @zuzia-dev
What's your opinion on using the settings menu like this, instead of adding it to the root page?