Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve inconsinstency with min_width working as (not existing before) fixed_width #560

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

bhirsz
Copy link
Member

@bhirsz bhirsz commented Aug 17, 2023

For AlignVariablesSection and AlignSettingsSection transformers.

Fixes #558

@bhirsz bhirsz requested a review from mnojek as a code owner August 17, 2023 08:46
@bhirsz bhirsz force-pushed the fix/min_width_as_fixed_width branch from 161f9c6 to 74333af Compare August 17, 2023 08:46
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5e90b16) 96.95% compared to head (74333af) 96.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage   96.95%   96.96%           
=======================================
  Files          49       49           
  Lines        4867     4873    +6     
=======================================
+ Hits         4719     4725    +6     
  Misses        148      148           
Files Changed Coverage Δ
robotidy/transformers/AlignSettingsSection.py 100.00% <100.00%> (ø)
robotidy/transformers/AlignVariablesSection.py 98.80% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhirsz bhirsz merged commit d0ff174 into main Aug 21, 2023
7 checks passed
@bhirsz bhirsz deleted the fix/min_width_as_fixed_width branch August 21, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment keywords use min_width in a confusing way
3 participants