output errors on the error stream #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at those click.echo I started to wonder if I do use click.echo everything or I mix it with print() even for errors.. but that's not the scope of this PR - I will check that later. Thanks for improving stderr/stdout part as it does make difference on unix systems, also allowing to filter out actual errors from diff output |
kkotenko
changed the title
|
Alright, thanks for taking a look. I have removed the WIP marker and consider this ready-to-merge. |
bhirsz
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits errors out into stderr.
It is debatable whether all tests which currently use result.output should be adjusted to explicitly check for stderr vs stdout. I have not yet done so, except to fix the tests that would now echo to stderr.