Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit GrapherDataMessage correctly for AdvancedDecoder #961

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

aq1018
Copy link
Contributor

@aq1018 aq1018 commented Nov 26, 2023

Hi there,

I was working on a custom TraceDecoder to display trace data via RTT. However, I wasn't seeing any data being displayed on the real time graph. After looking at the difference between the GraphDecoder and AdvancedDecoder, I realized that the AdvancedDecoder.graphData() was emitting data event, where as the GraphDecoder was emitting message event. After making the tweak, I was able to get the trace data showing nicely on the graph.

Screenshot 2023-11-26 at 6 17 40 AM Screenshot 2023-11-26 at 6 18 14 AM

@haneefdm
Copy link
Collaborator

You are correct, but this is a breaking change. I have to think about how to handle this

@haneefdm haneefdm merged commit 9609105 into Marus:master Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants