-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for EAD parameters #359
Comments
Hi @michaelwitting, |
This would be a potential example: I have an open PR (#347) with the updated documentation for adding EAD, shall I also add the parameter? |
Thanks for the example. I would like to integrate that to massbank. We try to increase the usage of controlled vocabulary from the respective domain specific ontology. Im not familiar with this technique and resources I find are limited. In principle EAD should be a child of dissociation method, right? As far as I understand this method, its fragmenting molecules in an electron beam with adjustable level of kinetic energy. Maybe EAD is in principle just a marketing term of a vendor and its actually ECD. The problem with ECD in MS ontology is its annotation which limits this method to multiple protonated precursors in pos mode. I need to clarify if we want a new method EAD here or if we want to change description of ECD in the ontology. Please give me a little time to figure this out. |
You are right: EAD is a type of ECD. It uses a different range of energy compared to ECD, this it is why it is considered a different method. At the moment Sciex is the only vendor offering it. |
Ok, we have a pull request with EAD and the ZenoTOF 7600 instrument pending at the psi-ms-CV. Thats good. So I think I can go on with this. |
Hi Micheal, But please do not start right away. I would like to wait a little bit for comments from the community. |
Hi Rene, no problem. Just send me a message when I can start. I will change in the meantime my R script generating the MassBank records accordingly. |
Hi all, I'm now preparing several EAD spectra and would like to export them to MassBank format as well. Can I basically use the following subtags under
until we have another solution? I don't want to do an own flavour or style of MassBank to be able to export the stuff. |
Hi Michael,
Whats still missing:
|
Hi Rene, that is really nice, but how long will it still take? But the subtags are fine for the moment, or? |
My proposal, so that you can continue: You provide an example above. The EAD section would just change a little bit to
Is that possible for you? or do we need to substitute "EAD" with "[MS, MS:1003294, electron activated dissociation, ]" after you created your content? I will need to merge the current state of the software to main to make that work finally on our side. I will do that right now, but I would like to test it a bit before I merge it. |
Thanks I can work like this! |
Ok, I made some testing and went through the example file you provided. I identified some issues in this file. I fixed them and will attach the result of this here: And here is an explanation of the issues:
I hope you can solve this issues in your pipeline. If you have problems please contact me and we can try to find a solution. One more thing. Your peaklist looks like profile data. If you are able to process the spectrum to centroid mode, we would prefer centroid mode. The current record spec document can be found here record spec |
In the documentation it is |
All issues should be solved by now. I will start another round of processing with my pipeline later today. |
You are absolutely right. Didn't know this. In the past we had different terms for the same thing, in this case |
Dear all,
I'm preparing for the upload of some EAD spectra. MassBank is missing fields for different parameters important for EAD.
This would be:
I'm suggesting the following subtags under
AC$MASS_SPECTROMETRY
KINETIC_ENERGY
ELECTRON_CURRENT
REACTION_TIME
These should be only used if
EAD
is used inFRAGMENTATION_MODE
(compare with #347)Best,
Michael
The text was updated successfully, but these errors were encountered: