Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix libebml namespace usage after removing using namespace #133

Merged
merged 1 commit into from
Jan 7, 2024
Merged

fix libebml namespace usage after removing using namespace #133

merged 1 commit into from
Jan 7, 2024

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Jan 6, 2024

since b0d8c7b

And fix missing ShouldWrite usage that was switched in 4125c26.

robUx4 added a commit to robUx4/libmatroska that referenced this pull request Jan 6, 2024
@robUx4
fix generated code
e4643e1 
Requires Matroska-Org/foundation-source#133
@robUx4 robUx4 mentioned this pull request Jan 6, 2024
Merged
mbunkus
mbunkus requested changes Jan 6, 2024
View reviewed changes
spectool/schema_2_kaxsemantic_cpp.xsl Outdated Show resolved Hide resolved
@robUx4
fix libebml namespace usage after removing using namespace
ee4c0c1 
since b0d8c7b

And fix missing ShouldWrite usage that was switched in 4125c26.
This was referenced Jan 7, 2024
Merged
Merged
@robUx4 robUx4 merged commit a3a9fc7 into master Jan 7, 2024
2 of 3 checks passed
@robUx4 robUx4 deleted the libebml_ns branch January 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbunkus mbunkus mbunkus requested changes

@retokromer retokromer retokromer approved these changes

Assignees
No one assigned
Labels
spectools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robUx4 @mbunkus @retokromer