[1.x] Fix MemIOCallback buffer overflows #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the addition of 2 positive values is smaller than one of the values then we have an overflowing addition. In this case that means we are trying to read more data that is actually in our buffer. So we can use the same mechanism as reading too much data. (cherry picked from commit 4d577f5) Signed-off-by: Steve Lhomme <slhomme@matroska.org>
If the addition of 2 positive values is smaller than one of the values then we have an overflowing addition. In this case we will not be able to allocate that much, just return a size written as 0. (cherry picked from commit 2d5c11c) Signed-off-by: Steve Lhomme <slhomme@matroska.org>
mbunkus
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #148 for the 1.x branch.