[RFC] Store the default value in a union inside EbmlSemantic #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
api-break
robUx4
force-pushed
the
semantic_default_union
branch
from
271c128
to
1fbb1ed
Compare
robUx4
force-pushed
the
semantic_default_union
branch
from
1fbb1ed
to
f2fc819
Compare
mbunkus
reviewed
Dec 18, 2023
ebml/EbmlElement.h
Outdated
|
|
||
| inline const DefaultValues & DefaultValue() const { return defaultValue; } | ||
|
|
||
| #if defined(EBML_STRICT_API) |
There was a problem hiding this comment.
EBML_STRICT_API has been removed with one of the commits over the last couple of days. Just always use private:
mbunkus
requested changes
Dec 18, 2023
robUx4
force-pushed
the
semantic_default_union
branch
3 times, most recently
from
79ea49c
to
c5473a1
Compare
robUx4
force-pushed
the
semantic_default_union
branch
from
c5473a1
to
7dafc65
Compare
|
This MR is just wrong, it should be stored alongside the EBML ID, not the semantic in the parent. And it turns out we already have macros to set the default value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A template might be cleaner, more type-safe. I gave it a try but it seemed very instrusive (all classes need to be touched).
This provides a basic system to set the default value in the semantic. If approve we can change how we set default values in libmatroska, using the new macros. And then we can switch the access to the default value to this storage in EbmlSemantic.