remove unused integer coding callbacks #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
api-break
mbunkus
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
I guess it doesn't really matter all that much, but personally I'd rather keep those functions in libEBML. They're dealing with EBML IDs; nothing about them is Matroska-specific. Other EBML-using formats might need similar/the same functions.
Of course all of that is theoretical as there are no known users other than libMatroska… so go ahead.
|
Signed EBML encoded are not a thing in EBML. They are a thing in Matroska. But as discussed before (some in libmatroska) there might have been more efficient ways to do it. I'd rather not spread this further than (lib)matroska. |
|
Ah right, hadn't paid attention to signed vs unsigned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145
The relevant code has been moved to libmatroska.