Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ID on cloned EbmlDummy and avoid default constructor #182

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Fix ID on cloned EbmlDummy and avoid default constructor #182

merged 2 commits into from
Dec 26, 2023

Commits on Dec 26, 2023

  1. fix Dummy cloning 

    The clone should have the same custom EBML ID, not the default one.
    @robUx4
    robUx4 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    9310d76 View commit details
    Browse the repository at this point in the history

  2. remove EbmlDummy default constructor 

    The whole point of EbmlDummy is to be a placeholder for elements with an unknown EBML ID.
It should not exist with a fake ID not corresponding to something read.
The current API makes some default creation mandatory but with don't have to allow
a local creation on top of that.
    @robUx4
    robUx4 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    f4c0f0b View commit details
    Browse the repository at this point in the history