Make the list of global elements non recursive #283

robUx4 · 2024-03-01T15:22:52Z

And rework the skipping of unknown/infinite length master elements.

With a bit more comments it's clearer what each part does. The handling of going to a parent level seems bogus.

We should be skipping data with the actual EbmlSemanticContext of that element.

No other code was executed after bEndFound was set to true to exist the loop.

We may find an upper level element in an unknown length master element. We skip its data as well, until there's nothing to skip. This is very suspicious.

We don't need to use the global context that contains the list of global elements. The global element cannot be a have an unknown size and will just skip the data and return nullptr.

Either the global element needs to be found in the list of elements, or though the callback. If the extra callback points to itself we may loop recursively on it.

mbunkus

mkvextract segfaults when reading certain files with these changes. There seems to be an infinite recursion happening with EbmlElement::SkipData() calling itself directly.

robUx4 added 5 commits March 1, 2024 16:18

simplify skipping data of a known child in unknown size master elements

4b3ae40

We should be skipping data with the actual EbmlSemanticContext of that element.

use regular break to exit loop

2368784

No other code was executed after bEndFound was set to true to exist the loop.

add a comment and reduce indentation

934d95b

We may find an upper level element in an unknown length master element. We skip its data as well, until there's nothing to skip. This is very suspicious.

skip global elements with their own context

67eaf75

We don't need to use the global context that contains the list of global elements. The global element cannot be a have an unknown size and will just skip the data and return nullptr.

make the global context non recursive

0f0314c

Either the global element needs to be found in the list of elements, or though the callback. If the extra callback points to itself we may loop recursively on it.

robUx4 added the enhancement label Mar 1, 2024

mbunkus requested changes Mar 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make the list of global elements non recursive #283

Make the list of global elements non recursive #283

robUx4 commented Mar 1, 2024

mbunkus left a comment

Make the list of global elements non recursive #283

Are you sure you want to change the base?

Make the list of global elements non recursive #283

Conversation

robUx4 commented Mar 1, 2024

mbunkus left a comment

Choose a reason for hiding this comment