Skip to content

Commit

Permalink
disable most verbose warnings in MSVC
Browse files Browse the repository at this point in the history
They are very noisy and not very useful.

the list of warnings can be found at https://learn.microsoft.com/en-us/cpp/preprocessor/compiler-warnings-that-are-off-by-default

Same as Matroska-Org/libebml@f9af4fd
  • Loading branch information
robUx4 committed Mar 3, 2024
1 parent c69b33a commit 360398d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ if(DEV_MODE)
add_cxx_flag_if_supported(-Wno-error=unused-command-line-argument
-Wall -Wextra -Wpedantic -Wfatal-errors -fstack-protector-strong
-Wno-self-assign
-Wcast-align)
-Wcast-align
-W4)
endif()

set(libmatroska_SOURCES
Expand Down
6 changes: 6 additions & 0 deletions test/mkvtree/mkvtree.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@

using namespace libebml;

#ifdef _WIN32
# if !WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP)
#define localtime(x) nullptr
# endif // UWP, Xbox, etc
#endif // win32

static int ShowPos = 0;

#if 0 // TODO allowing find top level elements using an EbmlSemanticContextMaster
Expand Down

0 comments on commit 360398d

Please sign in to comment.