clang-tidy: missing ShouldWrite const ref

Found with performance* Signed-off-by: Rosen Penev <rosenp@gmail.com>
Matroska-Org · Feb 1, 2024 · 8499b26 · 8499b26
1 parent 67a8ada
commit 8499b26
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/matroska/KaxCluster.h b/matroska/KaxCluster.h
@@ -46,7 +46,7 @@ DECLARE_MKX_MASTER_CONS(KaxCluster)
     /*!
       \brief Render the data to the stream and retrieve the position of BlockGroups for later cue entries
     */
-    libebml::filepos_t Render(libebml::IOCallback & output, KaxCues & CueToUpdate, ShouldWrite writeFilter = WriteSkipDefault);
+    libebml::filepos_t Render(libebml::IOCallback & output, KaxCues & CueToUpdate, const ShouldWrite& writeFilter = WriteSkipDefault);
 
     /*!
       \return the global timestamp of this Cluster

diff --git a/matroska/KaxCues.h b/matroska/KaxCues.h
@@ -34,7 +34,7 @@ DECLARE_MKX_MASTER(KaxCues)
     /*!
       \brief override to sort by timestamp/track
     */
-    libebml::filepos_t Render(libebml::IOCallback & output, ShouldWrite writeFilter = WriteSkipDefault) {
+    libebml::filepos_t Render(libebml::IOCallback & output, const ShouldWrite& writeFilter = WriteSkipDefault) {
       Sort();
       return EbmlMaster::Render(output, writeFilter);
     }

diff --git a/src/KaxCluster.cpp b/src/KaxCluster.cpp
@@ -113,7 +113,7 @@ bool KaxCluster::AddFrame(const KaxTrackEntry & track, std::uint64_t timestamp,
 /*!
   \todo only put the Blocks written in the cue entries
 */
-filepos_t KaxCluster::Render(IOCallback & output, KaxCues & CueToUpdate, ShouldWrite writeFilter)
+filepos_t KaxCluster::Render(IOCallback & output, KaxCues & CueToUpdate, const ShouldWrite& writeFilter)
 {
   filepos_t Result = 0;