Set CMAKE_CURRENT_BINARY_DIR as public #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM cc @mbunkus |
mbunkus
added a commit
that referenced
this pull request
Jul 29, 2023
Allows using libmatroska via add_subdirectory. libebml already had a similar change applied a while ago. Supersedes #111.
|
I've solved this slightly differently in 44aefa8. It matches the change in libebml & removes the now superfluous Please give it a try & open a new bug if it doesn't solve your issue. |
|
Why do you steal my idea and contributon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to build https://github.com/Azure/azure-storage-azcopy for ubuntu22.04
I can avoid errors of libebml by https://github.com/Matroska-Org/libebml/pull/140/files .
I need the same chane for the libmatroska.