Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic to match the generated code from v19 #112

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Sep 3, 2023

  • TrackOverlay is deprecated
  • update some enum comments

@robUx4 robUx4 added the Semantic Change in the semantic interepretation label Sep 3, 2023
@robUx4 robUx4 requested a review from mbunkus September 10, 2023 07:54
Copy link
Contributor

@mbunkus mbunkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, overlooked this one. It's fine, but doesn't apply anymore due to the changes wrt. write filter etc. Can you please rebuild it? Thanks.

So it matches the generated code.

The formatting could be improved. The references could be replaced. But
those changes should go in the generator first.
@mbunkus mbunkus merged commit 7019226 into master Jan 27, 2024
15 checks passed
@robUx4 robUx4 deleted the matroska-v19 branch January 28, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Semantic Change in the semantic interepretation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants