Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use the libebml namespace globally in definition files #144

Closed
wants to merge 1 commit into from
Closed

don't use the libebml namespace globally in definition files #144

wants to merge 1 commit into from

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Dec 31, 2023

No description provided.

@robUx4 robUx4 mentioned this pull request Dec 31, 2023
Merged
@robUx4
Copy link
Contributor Author

robUx4 commented Dec 31, 2023

This is just a test to show what needs a namespace and what doesn't. It builds when ShouldWrite and all the Ebml<Type> classes are not set a libebml namespace.

It's not a big deal, but I'd rather have nothing implied if possible.

@robUx4 robUx4 closed this Jan 1, 2024
@robUx4 robUx4 deleted the wip_no_namespace branch January 1, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbunkus mbunkus mbunkus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robUx4 @mbunkus