Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] keep the min/max/webm/divx information for each element #148

Closed
wants to merge 4 commits into from

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Jan 6, 2024

Based on Matroska-Org/libebml#207

For now it's only informational but it can be used later for a libmatroska-based mkvalidator/mkclean. The way it's handled may evolve given how I manage to recode these tools.

@robUx4 robUx4 added api-break breaks the API (e.g. programs using it will have to adjust their source code) abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) labels Jan 6, 2024
@mbunkus
Copy link
Contributor

mbunkus commented Jan 13, 2024

This branch doesn't merge with the current master at the moment. This prevents me from reviewing the corresponding libEBML PRs (Matroska-Org/libebml#207, Matroska-Org/libebml#211). Can you please rebase it (or probably regenerate KaxSemantic.cpp, probably faster)? Thanks.

@robUx4
Copy link
Contributor Author

robUx4 commented Jan 14, 2024

I rebased this branch, the libmatroska one and the spectools one.

@mbunkus mbunkus closed this Jan 14, 2024
@mbunkus
Copy link
Contributor

mbunkus commented Jan 14, 2024

I did merge & push the branch… not sure why Github thinks I didn't?

@robUx4 robUx4 deleted the min_max branch January 14, 2024 09:55
@robUx4
Copy link
Contributor Author

robUx4 commented Jan 14, 2024

Indeed, that's weird but the code seems to be OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) api-break breaks the API (e.g. programs using it will have to adjust their source code)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants