Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass ShouldWrite by const reference #170

Merged
merged 1 commit into from
Jan 28, 2024
Merged

pass ShouldWrite by const reference #170

merged 1 commit into from
Jan 28, 2024
+100 −100

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Jan 28, 2024

Necessary for Matroska-Org/libebml#231

Some code generated with Matroska-Org/foundation-source#142

@robUx4 robUx4 added enhancement api-break breaks the API (e.g. programs using it will have to adjust their source code) abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) labels Jan 28, 2024
@mbunkus mbunkus merged commit 8b5bb73 into Matroska-Org:master Jan 28, 2024
0 of 15 checks passed
@robUx4 robUx4 deleted the should_ref branch January 28, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) api-break breaks the API (e.g. programs using it will have to adjust their source code) enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robUx4 @mbunkus