Fix crashes in test6 #177
Merged
Fix crashes in test6 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a perfect world it should not even compile.
Both the Cluster and the reference handler think they own the block.
|
Due to this I've long since used a derived class from |
mbunkus
approved these changes
Feb 17, 2024
|
Maybe we can use weak references in 2.0 https://en.cppreference.com/w/cpp/memory/weak_ptr ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176, this will need a backport.
The Block reference handling seems bogus as it thinks it owns the reference Block. It seems mkvtoolnix doesn't use this (muxing) feature so no problem there.
We may fix it in 2.0 or just remove the feature.