-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch refactor to main #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just an idea I had, I might completely remove it, but I think having access to underlying, previously hard-coded messages is a good idea.
This is a really old class, it was made in Java by someone else (I cannot remember who sorry :( ), It was adapted for KTBukkitGui and written in Kotlin, but I see no need for it since I have never used it. If requested, this change will be reverted but for now use the DSL Item builder instead.
KTBukkitGui will not support buttons being defined in YAML primatively. I might implement some sort of JSON compatibility but the purpose of KTBukkitGui is to help developers make dynamic guis quicker.
Scoreboards with components don't seem to update automatically...
We now use an `effect` block to use Signals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KTGUI has not had a complete overhaul, for the latest versions, code will need to be adapted to fit new standards like using Adventure Components.