Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftPM 5.3 support with resource bundle and watchOS support #294

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

maniramezan
Copy link

This is currently WIP due to Swift 5.3 being in beta. This CR includes the work for fixing the unit tests in addition to prevent app crashing due to unavailability of the bundle. This is based on the #291 PR, but if that branch deosn't get merged in by the time Xcode 12 / Swift 5.3 is released, this can be cleaned up and used instead and the other PR should be disregarded.

@maniramezan maniramezan marked this pull request as draft July 7, 2020 04:38
@pontusm
Copy link

pontusm commented Sep 21, 2020

Would it be possible to support watchOS as well? We are using DateTools on watchOS today, but with Cocoapods. We are planning to migrate to SPM in the future.

@maniramezan
Copy link
Author

@pontusm Not much familiar with limitations of WatchOS, but can definitely look into it and enable it as part of this PR. I'm planning to clean it up and make the final version of it this week. I'll merge it into master branch on my fork and leave the PR open for the maintainer to decide if want to merge it in or when.

@pontusm
Copy link

pontusm commented Sep 22, 2020

That would be great! As I mentioned, we already use it on watchOS so I don't think you have to do much to support it. Probably just need to add it to the "platforms" list in the package file.

@maniramezan maniramezan force-pushed the mani_swiftpm_5_3 branch 2 times, most recently from b5f0129 to 7e67b02 Compare October 5, 2020 03:09
@maniramezan maniramezan changed the title [WIP] SwiftPM 5.3 support SwiftPM 5.3 support with resource bundle and watchOS support Oct 9, 2020
@maniramezan maniramezan marked this pull request as ready for review October 9, 2020 04:00
@maniramezan
Copy link
Author

@pontusm It's ready for being merge into the main branch. I'm going to merge it into my fork, so feel free to use that.

@atrbx5
Copy link

atrbx5 commented Jan 18, 2021

tried and getting error
ld: warning: directory not found for option '***/Carthage/Build/iOS'
ld: framework not found DateToolsSwift

@maniramezan
Copy link
Author

@atrbx5 I don't know if this library supports Carthage, #184 is what I found in previous issues.

@atrbx5
Copy link

atrbx5 commented Jan 20, 2021

ok figured out, long ago i was using cartage on the project and not all OTHER_LDFLAGS was removed
so when import it with SPM it was still looking for binary
works ok now

@daltonclaybrook
Copy link

Any update on this?

@maniramezan
Copy link
Author

It is merged in my fork. Feel free to use that or fork from mine. I've only added SPM support and fixed some tests, no other changes are in this fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants