Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
We noticed, thanks to my colleague @javiergm1983, that the constant value
SECONDS_IN_YEAR
is not correct. I do not know if you did it on purpose but following the standard convention, if it is considered a Gregorian year (365.2425 days), and a day are 86400 seconds, its value should be 52 seconds more.SECONDS_IN_YEAR = (365.2425 days) * (86400 seconds/day) = 31556952 seconds
I took the liberty to add a few new constants that somebody might find useful:
Please let me know if you like and found this code useful.
Thank you.
Cheers!