fix: reply to the legacy PIN request instead of letting the pair hang - #110
Merged
Conversation
`devicePairingPINCodeRequest` logged the request and returned without calling `replyPINCode`, which the delegate contract requires. Any peripheral that falls back to legacy PIN pairing sat in `.connecting` until the 60s pair watchdog fired, every attempt. Reply with the all-zero PIN legacy HID peripherals use, and only for a pair this app installed in `pendingPairs` — a request belonging to any other pair is left alone rather than answered on its behalf.
|
🎉 This PR is included in version 2.25.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devicePairingPINCodeRequestlogged the request and returned. The delegate contract requiresreplyPINCodein response ("must be invoked in response and happen before the timeout period of the device"), so any peripheral that falls back to legacy PIN pairing sat at "Pairing…" until the 60s watchdog, every attempt.Reply with the all-zero PIN legacy HID peripherals use, and only for a pair this app installed in
pendingPairs— a request belonging to any other pair is left alone rather than answered on its behalf. Same gating and main-hop as the confirmation handler in #107, so the two compose.Found while looking into #109; independent of it.