test(sample-controllers): demonstrate messenger interactions - #10013
Open
revisedbytom wants to merge 1 commit into
Open
test(sample-controllers): demonstrate messenger interactions#10013revisedbytom wants to merge 1 commit into
revisedbytom wants to merge 1 commit into
Conversation
Show how controller tests can assert delegated action calls and published state events without changing production behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adds focused examples to the sample controller tests showing how to:
This keeps production behavior unchanged and addresses #6766.
References
Fixes #6766
Changelog
No changelog entry is needed because this only changes test examples.
Checklist
Test commands
corepack yarn workspace @metamask/sample-controllers run jest --no-coverage packages/sample-controllers/src/sample-gas-prices-controller.test.ts packages/sample-controllers/src/sample-petnames-controller.test.tscorepack yarn eslint packages/sample-controllers/src/sample-gas-prices-controller.test.ts packages/sample-controllers/src/sample-petnames-controller.test.tscorepack yarn oxfmt --check packages/sample-controllers/src/sample-gas-prices-controller.test.ts packages/sample-controllers/src/sample-petnames-controller.test.tscorepack yarn buildMade with Cursor