Skip to content

fix(perps): handle partial Scale order acceptance #9989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abretonc7s wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix(perps): handle partial Scale order acceptance #9989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e4ccf2d
fix(perps): handle partial Scale order acceptance
abretonc7s Aug 27, 2026
f06f213
docs(perps): document Scale partial acceptance
abretonc7s Aug 27, 2026
b99db42
test(perps): clarify Scale recovery coverage
abretonc7s Aug 27, 2026
f684d2e
docs(perps): clarify Scale child order IDs
abretonc7s Aug 27, 2026
7c09aac
fix(perps): recover partial Scale SDK responses
abretonc7s Aug 27, 2026
679a6f0
fix(perps): validate partial Scale statuses
abretonc7s Aug 27, 2026
8f617b6
Merge origin/main into fix/perps-scale-partial-acceptance
abretonc7s Aug 28, 2026
8e3b7fc
fix(perps): align Scale result contract
abretonc7s Aug 28, 2026
da15149
fix(perps): clean up unclassified Scale rungs
abretonc7s Aug 28, 2026
27fc85d
chore(perps): merge main
abretonc7s Aug 28, 2026
0ebb349
fix(perps): address scale review feedback
abretonc7s Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/perps-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Preserve accepted HyperLiquid Scale orders when part of a batch is rejected ([#9989](https://github.com/MetaMask/core/pull/9989))

## [14.0.0]

### Added
Expand Down
10 changes: 10 additions & 0 deletions packages/perps-controller/src/constants/eventNames.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ export const PERPS_EVENT_PROPERTY = {
ORDER_SIZE: 'order_size',
MARGIN_USED: 'margin_used',
ORDER_TYPE: 'order_type', // lowercase per dashboard
SCALE_ORDER_COUNT: 'scale_order_count',
SCALE_RANGE_PCT: 'scale_range_pct',
SCALE_SKEW: 'scale_skew',
REDUCE_ONLY: 'reduce_only',
ORDER_TIMESTAMP: 'order_timestamp',
LIMIT_PRICE: 'limit_price',
FEES: 'fees',
Expand Down Expand Up @@ -478,6 +482,8 @@ export const PERPS_EVENT_VALUE = {
SLIPPAGE_CONFIG_OPENED: 'slippage_config_opened',
SLIPPAGE_CONFIG_CHANGED: 'slippage_config_changed',
SLIPPAGE_LIMIT_BLOCKED_ORDER: 'slippage_limit_blocked_order',
SCALE_CONFIG_CHANGED: 'scale_config_changed',
SCALE_VALIDATION_ERROR_SHOWN: 'scale_validation_error_shown',
// Auto Close TP/SL RoE sign toggle
TPSL_ROE_SIGN_TOGGLED: 'tpsl_roe_sign_toggled',
// Discovery analytics
Expand Down Expand Up @@ -587,6 +593,10 @@ export const PERPS_EVENT_VALUE = {
SETTING_TYPE: {
LEVERAGE: 'leverage',
SLIPPAGE: 'slippage',
SCALE_START_PRICE: 'start_price',
SCALE_END_PRICE: 'end_price',
SCALE_TOTAL_ORDERS: 'total_orders',
SCALE_SIZE_SKEW: 'size_skew',
},
SCREEN_NAME: {
CONNECTION_ERROR: 'connection_error',
Expand Down
1 change: 1 addition & 0 deletions packages/perps-controller/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ export type {
TPSLTrackingData,
OrderParams,
OrderResult,
ScaleOrderChild,
ChaseOrder,
ChaseOrderMaxDistanceReached,
ChaseOrderStatus,
Expand Down
Loading