Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/app/_locales/pt/messages.json messages translated.patch #22782

Closed
wants to merge 0 commits into from

Conversation

todearaujo
Copy link

@todearaujo todearaujo commented Feb 1, 2024

Description

This pull request addresses a series of missing translations within the app/_locales/pt/messages.json file of the MetaMask extension. The motivation behind these changes is to enhance the user experience for Portuguese-speaking users by providing a fully localized interface that was previously inconsistent due to untranslated strings.

Key improvements include:

  • Comprehensive translation of previously overlooked JSON values.
  • Verification and correction of existing translations for accuracy and context appropriateness.
  • Ensuring translation uniformity across the entire messages.json file to maintain a coherent user experience.

The process involved cross-referencing the existing translations with standard terminology used in cryptocurrency and MetaMask's specific features, engaging with native speakers for linguistic nuances, and updating the JSON file accordingly.

Related issues

Fixes: #issue_number (Replace with the actual issue number or link that this PR addresses)

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved in the description above.
  • I've linked related issues using the Fixes: #issue_number syntax.
  • I've included manual testing steps below.
  • I've included screenshots/recordings of the corrected Portuguese UI, if applicable.
  • I’ve included tests verifying the new translations if applicable.
  • I’ve documented my code using JSDoc format for any new functions or modified logic.
  • I’ve applied the appropriate labels on the PR, including enhancement for new feature additions and i18n for internationalization work.
  • I’ve properly set the pull request status to "ready for review" after ensuring all checkboxes above are complete.

Manual Testing Steps

  1. Navigate to the settings page of the MetaMask extension.
  2. Change the language preference to Portuguese.
  3. Verify that all settings descriptions, tooltips, and warnings are accurately translated.
  4. Perform transactions to ensure that all transaction-related messages are properly displayed in Portuguese.

Pre-merge reviewer checklist

  • I've manually tested the PR as described in the manual testing steps.
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings or screenshots.
I have read the CLA Document and I hereby sign the CLA

@todearaujo todearaujo requested a review from a team as a code owner February 1, 2024 23:12
Copy link
Contributor

github-actions bot commented Feb 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 1, 2024
@todearaujo
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@todearaujo todearaujo closed this Feb 1, 2024
@todearaujo todearaujo reopened this Feb 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
@todearaujo todearaujo closed this Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants