test: Complete missing step for add a contact to the address book in existing E2E test

[benjisclowder]

Description

Adding missing "add contact" step to this E2E test test/e2e/tests/settings/address-book.spec.js to fully cover the manual scenario here.

Related issues

Fixes: #27369

Manual testing steps

1. Run yarn test:e2e:single test/e2e/tests/settings/address-book.spec.js --browser=chrome --leave-running
2. Test should pass with no failure
3. The second test run in the test suite is the one added in this PR

Note: I have used the class instead of specific selectors (text+tag) for the element as the latter (Add contact/button) would not be located when running the test and the test would consistently fail.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [dfc8f17]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1795 ± 111 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1570	2598	1800	241	115
		domContentLoaded	1525	2530	1759	232	111
		load	1569	2541	1795	231	111
		domInteractive	16	199	54	45	22
		backgroundConnect	8	163	40	38	18
		firstReactRender	45	285	100	60	29
		getState	5	84	20	21	10
		initialActions	0	0	0	0	0
		loadScripts	1070	2121	1308	238	114
		setupStore	10	93	39	28	13
		uiStartup	1709	2752	2029	265	127

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[hjetpoluru]

Nice effort, @benjisclowder! I have added some feedback and potential replacements.

I notice that the file itself has a lot of anti-patterns. Once these changes are made, if you feel comfortable, update this spec file and try to adapt the POM.

[hjetpoluru]

@benjisclowder, code looks good now. Just fix the lint errors and get the latest develop and will approve the PR.

[chloeYue]

Hi @benjisclowder , could you remove the added submodule as it's not necessary? thanks !

[metamaskbot]

Builds ready [81a2c2c]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2123 ± 86 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	320	2608	2022	425	204
		domContentLoaded	1791	2409	2078	166	80
		load	1864	2588	2123	179	86
		domInteractive	30	87	51	17	8
		backgroundConnect	8	196	50	42	20
		firstReactRender	64	222	114	35	17
		getState	5	85	25	25	12
		initialActions	0	1	0	0	0
		loadScripts	1308	1814	1535	139	67
		setupStore	12	103	33	26	12
		uiStartup	2040	2865	2392	214	103

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[benjisclowder]

Hi, @hjetpoluru and @chloeYue! Thanks a lot for the feedback and suggestions. All changes have been made and PR is ready for approval.

[hjetpoluru]

LGTM