fix: error in navigating between transaction when one of the transaction is approve all

[jpuri]

Description

Navigation in transaction header was broken when one of the transaction is of type Approve All

Related issues

Fixes: #27913

Manual testing steps

1. Go to test dapp
2. Submit any re-designed transaction followed by an approve all transaction
3. Try navigating between transaction using header buttons

Screenshots/Recordings

TODO

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[jpuri]

Reason for the big for that this hook was being called conditionally

[matthewwalsh0]

To make this more explicit and readable, could we use an object argument call this something like transactionTypeFilter?

We could also omit the filter completely and always decode but I appreciate this is a nice optimisation.

If we end up with many of usages of this hook, we may want to implement some kind of caching in the underlying background utils, or even move this to the TransactionController.

[metamaskbot]

Builds ready [14a5895]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2085 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	260	2825	1909	568	273
		domContentLoaded	1801	2680	2047	180	86
		load	1822	2703	2085	177	85
		domInteractive	24	95	49	20	10
		backgroundConnect	9	72	37	21	10
		firstReactRender	63	133	100	17	8
		getState	6	100	32	29	14
		initialActions	0	1	0	0	0
		loadScripts	1324	2013	1521	141	68
		setupStore	13	78	35	23	11
		uiStartup	2059	3035	2322	208	100

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 82 Bytes (0.00%)
• common: 0 Bytes (0.00%)