-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [POM] Migrate edit network rpc e2e tests and create related page class functions #28161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloeYue
added
team-extension-platform
e2e-test
End to end test for the MetaMask extension
area-qa
Relating to QA work (Quality Assurance)
labels
Oct 29, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
chloeYue
changed the title
test: Edit network rpc
test: [POM] Migrate edit network rpc e2e tests and create related page class functions
Oct 29, 2024
chloeYue
force-pushed
the
edit-network-rpc
branch
from
October 30, 2024 13:05
699fb10
to
2488280
Compare
Builds ready [616eb81]
Page Load Metrics (2084 ± 127 ms)
Bundle size diffs
|
seaona
reviewed
Oct 31, 2024
seaona
previously approved these changes
Oct 31, 2024
hjetpoluru
reviewed
Oct 31, 2024
hjetpoluru
reviewed
Oct 31, 2024
Co-authored-by: Harika <153644847+hjetpoluru@users.noreply.github.com>
hjetpoluru
reviewed
Oct 31, 2024
Builds ready [0089519]
Page Load Metrics (2112 ± 130 ms)
Bundle size diffs
|
hjetpoluru
reviewed
Oct 31, 2024
Builds ready [506d3d9]
Page Load Metrics (2017 ± 61 ms)
Bundle size diffs
|
hjetpoluru
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seaona
approved these changes
Nov 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2024
metamaskbot
added
the
release-12.8.0
Issue or pull request that will be included in release 12.8.0
label
Nov 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-qa
Relating to QA work (Quality Assurance)
e2e-test
End to end test for the MetaMask extension
release-12.8.0
Issue or pull request that will be included in release 12.8.0
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test/e2e/tests/network/multi-rpc.spec.ts
e2e tests to Page Object Model (POM) pattern.Related issues
Fixes: #28163
Manual testing steps
Check code readability, make sure tests pass.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist