Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [POM] Migrate edit network rpc e2e tests and create related page class functions #28161

Merged
merged 11 commits into from
Nov 4, 2024

Conversation

chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Oct 29, 2024

Description

  • Migrate test/e2e/tests/network/multi-rpc.spec.ts e2e tests to Page Object Model (POM) pattern.
  • Created edit network related page classes and functions
  • Removed unnecessary delay by correctly implementing page object functions
  • Objective of this PR is to improve test stability and maintainability, it also reduced flakiness.
  • update: it also fixes the flaky test Update Network

Open in GitHub Codespaces

Related issues

Fixes: #28163

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue added team-extension-platform e2e-test End to end test for the MetaMask extension area-qa Relating to QA work (Quality Assurance) labels Oct 29, 2024
@chloeYue chloeYue self-assigned this Oct 29, 2024
@chloeYue chloeYue requested a review from a team as a code owner October 29, 2024 16:03
@chloeYue chloeYue marked this pull request as draft October 29, 2024 16:03
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue changed the title test: Edit network rpc test: [POM] Migrate edit network rpc e2e tests and create related page class functions Oct 29, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [616eb81]
Page Load Metrics (2084 ± 127 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint182929412091263126
domContentLoaded176629292057267128
load177629462084264127
domInteractive15129572512
backgroundConnect876292010
firstReactRender521981053015
getState464272512
initialActions01000
loadScripts129723361532242116
setupStore1292422713
uiStartup198732362339284137
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue marked this pull request as ready for review October 30, 2024 13:55
seaona
seaona previously approved these changes Oct 31, 2024
Co-authored-by: Harika <153644847+hjetpoluru@users.noreply.github.com>
@metamaskbot
Copy link
Collaborator

Builds ready [0089519]
Page Load Metrics (2112 ± 130 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42925252006438210
domContentLoaded167725552085258124
load168525612112270130
domInteractive3496612010
backgroundConnect981262412
firstReactRender512171103215
getState487172010
initialActions01000
loadScripts117518861499215103
setupStore1195352612
uiStartup189730322357313150
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [506d3d9]
Page Load Metrics (2017 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37522081854476229
domContentLoaded17842329198512560
load18392337201712861
domInteractive17101512211
backgroundConnect9142333316
firstReactRender502941094924
getState55820189
initialActions01000
loadScripts1320166114769847
setupStore12106362713
uiStartup20762746226718589
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@hjetpoluru hjetpoluru self-requested a review October 31, 2024 18:28
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloeYue chloeYue added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024
@chloeYue chloeYue added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024
@chloeYue chloeYue added this pull request to the merge queue Nov 4, 2024
Merged via the queue into develop with commit cdfaa42 Nov 4, 2024
82 checks passed
@chloeYue chloeYue deleted the edit-network-rpc branch November 4, 2024 10:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) e2e-test End to end test for the MetaMask extension release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[POM] Create edit network base functions and migrate e2e tests
4 participants