-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove global network usage from signatures #28167
Merged
matthewwalsh0
merged 5 commits into
develop
from
refactor/remove-global-network-usage-signatures
Nov 4, 2024
Merged
refactor: remove global network usage from signatures #28167
matthewwalsh0
merged 5 commits into
develop
from
refactor/remove-global-network-usage-signatures
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team-confirmations
Push issues to confirmations team
label
Oct 29, 2024
Base automatically changed from
chore/upgrade-signature-controller-remove-global-network
to
develop
October 30, 2024 11:02
matthewwalsh0
force-pushed
the
refactor/remove-global-network-usage-signatures
branch
from
October 30, 2024 13:54
6ea4e7e
to
5eae3ec
Compare
Builds ready [6846f69]
Page Load Metrics (1765 ± 87 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
approved these changes
Nov 1, 2024
vinistevam
approved these changes
Nov 4, 2024
matthewwalsh0
deleted the
refactor/remove-global-network-usage-signatures
branch
November 4, 2024 10:12
metamaskbot
added
the
release-12.8.0
Issue or pull request that will be included in release 12.8.0
label
Nov 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA Passed
release-12.8.0
Issue or pull request that will be included in release 12.8.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove global network usage from all signature components and hooks.
Specifically:
getCurrentChainId
getNativeCurrency
getProviderConfig
selectNetworkConfigurationByChainId
selectDefaultRpcEndpointByChainId
Related issues
Fixes: #3375 #3500 #3459 #3374
Manual testing steps
Regression of all signature types including legacy and redesigned confirmations.
Also verify Blockaid warnings.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist