Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use keccak256 from ethereum-cryptography #28170

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 30, 2024

Description

  • chore: use keccak256 from ethereum-cryptography

Legacy ethereum-util is deprecated and uses a simialrly legacy version of keccak. This replaces usage with ethereum-cryptography (@noble/hashes).

Open in GitHub Codespaces

Related issues

Blocked by

Blocking

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Oct 30, 2024
@legobeat legobeat added the type-tech-debt Technical debt label Oct 30, 2024
@legobeat legobeat force-pushed the deps-ethereumjs-util-keccak branch 2 times, most recently from 89b2759 to 1f4eeb0 Compare October 30, 2024 05:02
@legobeat legobeat marked this pull request as ready for review October 30, 2024 05:03
@legobeat legobeat requested review from a team as code owners October 30, 2024 05:03
@legobeat legobeat force-pushed the deps-ethereumjs-util-keccak branch 13 times, most recently from 7d5e9f3 to 529feb5 Compare November 5, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file team-security type-tech-debt Technical debt
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

1 participant