-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove global network usage from transaction confirmations #28236
Open
matthewwalsh0
wants to merge
9
commits into
develop
Choose a base branch
from
refactor/remove-global-network-usage-transactions
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: remove global network usage from transaction confirmations #28236
matthewwalsh0
wants to merge
9
commits into
develop
from
refactor/remove-global-network-usage-transactions
+413
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewwalsh0
changed the base branch from
develop
to
refactor/remove-global-network-usage-signatures
November 1, 2024 20:48
Base automatically changed from
refactor/remove-global-network-usage-signatures
to
develop
November 4, 2024 10:12
matthewwalsh0
force-pushed
the
refactor/remove-global-network-usage-transactions
branch
from
November 5, 2024 12:24
1a2436d
to
4751ebf
Compare
Builds ready [4751ebf]
Page Load Metrics (2019 ± 105 ms)
Bundle size diffs
|
Builds ready [64e464e]
Page Load Metrics (1940 ± 78 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
changed the title
refactor: remove global network usage from transactions
refactor: remove global network usage from transaction confirmations
Nov 5, 2024
Builds ready [43317f9]
Page Load Metrics (2003 ± 172 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove usages of global network selectors from transaction confirmation React components and hooks.
Specifically:
getConversionRate
getCurrentChainId
getNativeCurrency
getNetworkIdentifier
getNftContracts
getNfts
getProviderConfig
getRpcPrefsForCurrentProvider
selectConversionRateByChainId
selectNftsByChainId
selectNftContractsByChainId
selectNetworkIdentifierByChainId
Related issues
Fixes: #3469 #3373 #3486 #3487
Manual testing steps
Full regression of all transaction confirmations and related functionality.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist