-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix alignment of long RPC labels in Networks menu #28244
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -190,6 +194,9 @@ export const NetworkListItem = ({ | |||
as="button" | |||
variant={TextVariant.bodySmMedium} | |||
color={TextColor.textAlternative} | |||
textAlign={ | |||
textDirection === 'rtl' ? TextAlign.Right : TextAlign.Left |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TextAlign.Start
wasn't being respected so I needed to use textDirection
:/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!✅
d16da55
d16da55
to
4e04689
Compare
Builds ready [8eec9dd]
Page Load Metrics (1949 ± 88 ms)
Bundle size diffs
|
Description
Fixes alignment for long RPC labels in the networks list
Related issues
Fixes:
Manual testing steps
BNB Smart Chain (previously Binance Smart Chain Mainnet)
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist