Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix alignment of long RPC labels in Networks menu #28244

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Nov 1, 2024

Description

Fixes alignment for long RPC labels in the networks list

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Add BNB Chain to MetaMask
  2. Create a second RPC for it with the label BNB Smart Chain (previously Binance Smart Chain Mainnet)
  3. See the label left-aligned

Screenshots/Recordings

Before

image (2)

After

SCR-20241104-iwaw

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner November 1, 2024 17:22
Copy link
Contributor

github-actions bot commented Nov 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@@ -190,6 +194,9 @@ export const NetworkListItem = ({
as="button"
variant={TextVariant.bodySmMedium}
color={TextColor.textAlternative}
textAlign={
textDirection === 'rtl' ? TextAlign.Right : TextAlign.Left
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TextAlign.Start wasn't being respected so I needed to use textDirection :/

vinnyhoward
vinnyhoward previously approved these changes Nov 1, 2024
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!✅

sahar-fehri
sahar-fehri previously approved these changes Nov 1, 2024
@darkwing darkwing dismissed stale reviews from sahar-fehri and vinnyhoward via d16da55 November 4, 2024 15:17
@darkwing darkwing requested a review from a team as a code owner November 4, 2024 15:17
@metamaskbot
Copy link
Collaborator

Builds ready [8eec9dd]
Page Load Metrics (1949 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33324261789504242
domContentLoaded16942415192018287
load17082429194918488
domInteractive25215654421
backgroundConnect787312211
firstReactRender531991002914
getState46515178
initialActions0452105
loadScripts12551931143817283
setupStore1164262010
uiStartup19202634216619192
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 12 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing added this pull request to the merge queue Nov 4, 2024
Merged via the queue into develop with commit 63ea629 Nov 4, 2024
76 checks passed
@darkwing darkwing deleted the fix-network-rpc branch November 4, 2024 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants